I have camera canon 30D with lens ef s 17-85mm.I want to complete the lenses.Give me advise,which lenses ?

Depending on what you want to use it for.For General Photography another zoom, 75-300mm (or thereabouts) should suffice.

You could get three lenses like 28-105mm,75-300mm,wideangle converter 0.45x,Tele-converter 2x,that's best enough for your photography.

Something like a 70-200 f2.8 would be a great lens to get.

I have a 50mm macro that I can't live without, I'd recommend that as well. It's great for close-ups of things as well as portraits.

First, understand that all zoom lenses are a compromise in quality. I would not recommend any EF-S lens anymore since they will not work on full-frame cameras (like the 5D) which sooner than you think will be the norm. The following is what I have in my camera bag:

10-22mm EF-S (I wanted a wide-angle and this one does wonders. OK, it is a zoom and an EF-S. I am not recommending it to everyone.)

24mm L series f/1.4 (prime lens with plenty of light gathering. Good for those indoor large shots. Also pretty good for model full-body photos)

28-135mm IS USM f/3.5-6 (this is my walking around lens. Good range and lightweight, and a Canon. I love the Image Stabilization, which is worth another f-stop or two)

50 mm USM f/1.4 (This one they will have to pry out of my cold, dead fingers. I love this one. It is great for portraits and for fairly close stage shots. I did the entire Isla Vista Juggling Festival show using only this lens)

100-400mm L series IS (this is one heavy lens. It has the reach to get in close on rocket launches and birds. It is also great at sporting events or just people watching)

I shoot a Canon 30D now but did start with an EOS 300D and then went to a 350.

Add a 70-200 (either the F4L or F2.8L) and then the 300 (again F4L or F2.8L) and a 1.4 tc and you will have a pretty high quality kit. On a budget? Go go for the 75-300 instead.